Changeset 61367

Timestamp:

12/10/2025 11:25:48 PM (2 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [59132].

See #64324.

File:

• trunk/tests/phpunit/tests/blocks/registerBlockTypeFromMetadataWithRegistry.php (modified) (2 diffs)

trunk/tests/phpunit/tests/blocks/registerBlockTypeFromMetadataWithRegistry.php

@@ -45 +45 @@
         // Assert that the block was registered successfully
         $this->assertInstanceOf( 'WP_Block_Type', $registered_block );
-        $this->assertEquals( 'test-suite/test-block', $registered_block->name );
-        $this->assertEquals( 'Custom Test Block', $registered_block->title );
-        $this->assertEquals( 'widgets', $registered_block->category );
-        $this->assertEquals( 'smiley', $registered_block->icon );
-        $this->assertEquals( 'A test block registered via WP_Block_Metadata_Registry', $registered_block->description );
-        $this->assertEquals( array( 'html' => false ), $registered_block->supports );
+        $this->assertSame( 'test-suite/test-block', $registered_block->name );
+        $this->assertSame( 'Custom Test Block', $registered_block->title );
+        $this->assertSame( 'widgets', $registered_block->category );
+        $this->assertSame( 'smiley', $registered_block->icon );
+        $this->assertSame( 'A test block registered via WP_Block_Metadata_Registry', $registered_block->description );
+        $this->assertSame( array( 'html' => false ), $registered_block->supports );
     }
 
@@ -84 +84 @@
         // Assert that the block was registered successfully with overrides
         $this->assertInstanceOf( 'WP_Block_Type', $registered_block );
-        $this->assertEquals( 'test-suite/test-block', $registered_block->name );
-        $this->assertEquals( 'Overridden Title', $registered_block->title );
-        $this->assertEquals( 'widgets', $registered_block->category );
-        $this->assertEquals( 'smiley', $registered_block->icon );
-        $this->assertEquals( 'A test block registered via WP_Block_Metadata_Registry', $registered_block->description );
-        $this->assertEquals( array( 'html' => true ), $registered_block->supports );
+        $this->assertSame( 'test-suite/test-block', $registered_block->name );
+        $this->assertSame( 'Overridden Title', $registered_block->title );
+        $this->assertSame( 'widgets', $registered_block->category );
+        $this->assertSame( 'smiley', $registered_block->icon );
+        $this->assertSame( 'A test block registered via WP_Block_Metadata_Registry', $registered_block->description );
+        $this->assertSame( array( 'html' => true ), $registered_block->supports );
     }