Skip to content

Conversation

@crftwrk
Copy link
Member

@crftwrk crftwrk commented May 27, 2025

@crftwrk crftwrk added this to v7 May 27, 2025
@crftwrk crftwrk moved this to Todo in v7 May 27, 2025
@crftwrk crftwrk marked this pull request as draft May 27, 2025 08:13
@crftwrk crftwrk changed the title Update scssphp 2.0.0 Update scssphp 2.1.0 Dec 8, 2025
@justinkruit
Copy link
Member

Been a while, sorry!

Is there a reason this hasn't been merged?

@crftwrk
Copy link
Member Author

crftwrk commented Dec 10, 2025

Ah, good to hear from you. I reverted this PR because:

  • A user reported a fatal error
  • Requires at least PHP 8.1, and I'm not sure if every user is up to that standard
  • It's heavy and increases the zipped file size from current 1.0.1 MB to 1.6 MB

So, i think we should ship this with Bootstrap 6.

@justinkruit
Copy link
Member

  • A user reported a fatal error

I haven't had issues with it in production for months.

  • Requires at least PHP 8.1, and I'm not sure if every user is up to that standard

PHP 8.0 is already end of life. So if they use a hosting which don't support it, they should definitely move. WordPress also adds a big alert if your PHP version is out of date.

  • It's heavy and increases the zipped file size from current 1.0.1 MB to 1.6 MB

I don't think that matters all that much, it still is quite small.

@crftwrk
Copy link
Member Author

crftwrk commented Dec 10, 2025

Agree with that. But we should do a 6.3.1 release first, this is ready, just waiting for WC 10.4 which should be released yesterday. After that we can merge that PR immediately, release it in 6.4 and inform users.

Do you agree with that and do you want to do the 6.3.1 release?

@crftwrk crftwrk added this to v6.4.0 Dec 11, 2025
@crftwrk crftwrk moved this to In Progress in v6.4.0 Dec 11, 2025
@crftwrk crftwrk removed the v7 label Dec 11, 2025
@crftwrk
Copy link
Member Author

crftwrk commented Dec 15, 2025

@pro-wow you have reported an issue with that here. Can you please check if this issue still exists?

@justinkruit I have tested it on several sites and have no issues, please merge if you agree.

@crftwrk crftwrk marked this pull request as ready for review December 15, 2025 10:01
@crftwrk crftwrk requested a review from justinkruit December 15, 2025 10:02
@crftwrk
Copy link
Member Author

crftwrk commented Dec 15, 2025

Ouch, I also got a white screen using Mamp and PHP 8.2. I do not feel good to merge this now, let's do that in v7. scssphp v1 still works...

@crftwrk crftwrk marked this pull request as draft December 15, 2025 12:19
@crftwrk crftwrk removed this from v6.4.0 Dec 15, 2025
@crftwrk crftwrk added the v7 label Dec 15, 2025
@justinkruit
Copy link
Member

Ouch, I also got a white screen using Mamp and PHP 8.2.

Do you have a PHP error?

@crftwrk
Copy link
Member Author

crftwrk commented Dec 19, 2025

It's about the memory limit:

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 290816 bytes) in /Applications/MAMP/htdocs/wordpress/wp-content/themes/bootscore/inc/scssphp/scssphp/scssphp/src/Serializer/Serializer.php on line 47

Increased it and works fine now:

define('WP_MEMORY_LIMIT', '256M');
define('WP_MAX_MEMORY_LIMIT', '256M');

But i'm a bit afraid of how many sites will be affected on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants