-
-
Notifications
You must be signed in to change notification settings - Fork 109
Update scssphp 2.1.0 #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update scssphp 2.1.0 #1031
Conversation
Upstream main
Upstream main
Upstream main
Upstream main
Upstream main
Upstream main
Upstream main
Upstream main
Upstream main
Upstream main
Upstream main
|
Been a while, sorry! Is there a reason this hasn't been merged? |
|
Ah, good to hear from you. I reverted this PR because:
So, i think we should ship this with Bootstrap 6. |
I haven't had issues with it in production for months.
PHP 8.0 is already end of life. So if they use a hosting which don't support it, they should definitely move. WordPress also adds a big alert if your PHP version is out of date.
I don't think that matters all that much, it still is quite small. |
|
Agree with that. But we should do a 6.3.1 release first, this is ready, just waiting for WC 10.4 which should be released yesterday. After that we can merge that PR immediately, release it in 6.4 and inform users. Do you agree with that and do you want to do the 6.3.1 release? |
Merge `main` into #1031
|
@pro-wow you have reported an issue with that here. Can you please check if this issue still exists? @justinkruit I have tested it on several sites and have no issues, please merge if you agree. |
|
Ouch, I also got a white screen using Mamp and PHP 8.2. I do not feel good to merge this now, let's do that in v7. scssphp v1 still works... |
Do you have a PHP error? |
|
It's about the memory limit: Increased it and works fine now: define('WP_MEMORY_LIMIT', '256M');
define('WP_MAX_MEMORY_LIMIT', '256M');But i'm a bit afraid of how many sites will be affected on this. |
Requires:
See:
PR #909