-
Notifications
You must be signed in to change notification settings - Fork 30
Closed
Labels
corerelated to features in feos-corerelated to features in feos-corepcsaftRelated to the PC-SAFT modelRelated to the PC-SAFT model
Milestone
Description
When using PC-SAFT it is somewhat unclear which ideal gas model is used (see, e.g., #68). Should the selection be more explicit? Some thoughts:
- The default ideal gas model is nice to have because it leads to correct pressures and derivatives of pressures. However, calculating caloric properties with the default model should be discouraged. At the same time, residual caloric properties are fine.
- Caloric properties could be hidden behind a trait similar to mass specific properties. That would not solve the problem for PC-SAFT, though, which clearly should implement that trait.
- For PC-SAFT specifically there should probably be either one single method, or an explicit choice.
Then there is also the issue with models implemented in Python:
Metadata
Metadata
Assignees
Labels
corerelated to features in feos-corerelated to features in feos-corepcsaftRelated to the PC-SAFT modelRelated to the PC-SAFT model