Skip to content

Consider updating the format for performance results to make them compatible with Windows #4169

@yeikel

Description

@yeikel

I tried to clone a fresh copy of the project on Windows 10, and clone failed with the following error

>git clone https://github.com/yeikel/graphql-java.git
Cloning into 'graphql-java'...
remote: Enumerating objects: 63448, done.
remote: Counting objects: 100% (1750/1750), done.
remote: Compressing objects: 100% (412/412), done.
remote: Total 63448 (delta 1554), reused 1338 (delta 1338), pack-reused 61698 (from 6)
Receiving objects: 100% (63448/63448), 17.85 MiB | 20.08 MiB/s, done.
Resolving deltas: 100% (36476/36476), done.
error: invalid path 'performance-results/2024-11-28T01:53:48Z-1d50c655aaf1a907b65f39e2eba310f3463ba5d5-jdk17.json'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

I suspect that this may prevent some people from contributing to the project unless they use NIX systems.

I believe that we may be able to fix this if we do not Colon : in the filename as : is not allowed in filenames on Windows. One idea is to use underscores _ or dashes - instead

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions