fix Message.is_scheduled field always False when parsing UpdateNewScheduledMessage #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eduledMessage Signed-off-by: wulan17 <wulan17@nusantararom.org>
Member
|
Thank you for your contribution! |
alissonlauffer
approved these changes
Dec 21, 2023
HitaloM
requested changes
Dec 21, 2023
Member
HitaloM
left a comment
HitaloM
left a comment
There was a problem hiding this comment.
Thanks for the contribution, everything seems to be correct, the only thing missing is the news fragment for the changelog. @alissonlauffer could you do this?
HitaloM
added
bug
HitaloM
approved these changes
Dec 21, 2023
Member
HitaloM
left a comment
HitaloM
left a comment
There was a problem hiding this comment.
Now it's complete, great work from both of you. 🫡
tangyoha
pushed a commit
to tangyoha/hydrogram
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because i put topics parameter before is_scheduled in Message._parse method, everytime client get UpdateNewScheduledMessage updates the is_scheduled field will always False
Add the parameter name fix the issue
Type of change
How Has This Been Tested?
I test using my private bot, before this fix everytime i scheduled a message the is_scheduled field always return False and after this fix its return True
Test Configuration
Checklist