Add ChatBackground type and fix. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I still need to test it myself, but the code doesn't seem to have any problems at first glance, what's missing is proper formatting and linting according to the project's standards (with ruff). https://github.com/hydrogram/hydrogram/blob/dev/CONTRIBUTING.md#setting-up-development-environment |
HitaloM
requested changes
Jun 22, 2024
Member
HitaloM
left a comment
HitaloM
left a comment
There was a problem hiding this comment.
That's good, once the requested changes have been made, the pull request should be merged.
HitaloM
approved these changes
Jun 22, 2024
alissonlauffer
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 - Add
ChatBackgroundtype.2 - Add
backgroundfield forChattype.Note: only available forUserFull, andChannelFull,ChatFulldoesn't have 'wallpaper' field.3 - Fix type hint for
pinned_messageinChattype ( the docs said it must beMessage).4 - Update docs.
Note:
file_id.