File tree Expand file tree Collapse file tree 4 files changed +9
-10
lines changed
Expand file tree Collapse file tree 4 files changed +9
-10
lines changed Original file line number Diff line number Diff line change @@ -477,8 +477,7 @@ bool PluginInitialize(SBDebugger d) {
477477
478478 setPropertyCmd.AddCommand (" color" , new llnode::SetPropertyColorCmd (),
479479 " Set color property value" );
480- setPropertyCmd.AddCommand (" tree-padding" ,
481- new llnode::SetTreePaddingCmd (&llv8),
480+ setPropertyCmd.AddCommand (" tree-padding" , new llnode::SetTreePaddingCmd (),
482481 " Set tree-padding value" );
483482
484483 interpreter.AddCommand (" findjsobjects" , new llnode::FindObjectsCmd (&llscan),
Original file line number Diff line number Diff line change @@ -32,14 +32,10 @@ class SetPropertyColorCmd : public CommandBase {
3232
3333class SetTreePaddingCmd : public CommandBase {
3434 public:
35- SetTreePaddingCmd (v8::LLV8* llv8) : llv8_(llv8) {}
3635 ~SetTreePaddingCmd () override {}
3736
3837 bool DoExecute (lldb::SBDebugger d, char ** cmd,
3938 lldb::SBCommandReturnObject& result) override ;
40-
41- private:
42- v8::LLV8* llv8_;
4339};
4440
4541class PrintCmd : public CommandBase {
Original file line number Diff line number Diff line change @@ -647,7 +647,7 @@ void FindReferencesCmd::PrintRecursiveReferences(
647647 std::stringstream seen_str;
648648 seen_str << rang::fg::red << " [seen above]" << rang::fg::reset
649649 << std::endl;
650- result.Printf (seen_str.str ().c_str ());
650+ result.Printf (" %s " , seen_str.str ().c_str ());
651651 } else {
652652 visited_references->push_back (address);
653653 v8::Value value (llscan_->v8 (), address);
Original file line number Diff line number Diff line change @@ -111,7 +111,11 @@ double LLV8::LoadDouble(int64_t addr, Error& err) {
111111 }
112112
113113 err = Error::Ok ();
114- return *reinterpret_cast <double *>(&value);
114+ // dereferencing type-punned pointer will break strict-aliasing rules
115+ // return *reinterpret_cast<double*>(&value);
116+ double dvalue;
117+ std::memcpy (&dvalue, &value, sizeof (double ));
118+ return dvalue;
115119}
116120
117121
@@ -1288,8 +1292,8 @@ StackTrace::StackTrace(JSArray frame_array, Error& err)
12881292 if ((len_ != 0 ) ||
12891293 ((frame_array_.GetArrayLength (err) - 1 ) % multiplier_ != 0 )) {
12901294 Error::PrintInDebugMode (
1291- " JSArray doesn't look like a Stack Frames array. stack_len: %lld "
1292- " array_len: %lld " ,
1295+ " JSArray doesn't look like a Stack Frames array. stack_len: %d "
1296+ " array_len: %ld " ,
12931297 len_, frame_array_.GetArrayLength (err));
12941298 len_ = -1 ;
12951299 multiplier_ = -1 ;
You can’t perform that action at this time.
0 commit comments