Skip to content

Commit afaec48

Browse files
mmarchinimmarchini
committed
doc: update collaborator guide to match the project size
This commits modifies our collaborator guide to match the current project size. llnode is way smaller than nodejs/node, and requiring two approvals to land a change/one approval with a seven day wait can be quite bureaucratic. Two approvals represent 50% of our active reviewers at the moment, which is quite a lot. Changing the requirements to one approval with no wait time once a PR gets approved makes more sense for this project, and it also matches other smaller projects across the organization. PR-URL: #296 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent e1a74b0 commit afaec48

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

‎COLLABORATOR_GUIDE.md‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
# llnode Collaborator Guide
22

33
llnode follows the
4-
[Node.js Collaborator Guide](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md).
4+
[Node.js Collaborator Guide](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md),
5+
with the following differences:
6+
7+
- At least one Collaborator must approve a pull request before the pull
8+
request lands.
9+
- There's no minimum wait time for landing a pull request. Pull requests can
10+
land as soon as they get approved by at least one Collaborator.
11+
- Approval must be from Collaborators who are not authors of the change.

0 commit comments

Comments
 (0)