Skip to content

Conversation

@furious
Copy link
Contributor

@furious furious commented Sep 17, 2025

Calling baileys downloadMediaMessage or downloadContentFromMessage with parameter "mediaKey" with an object will fail.

Summary by Sourcery

Bug Fixes:

  • Convert mediaKey from object to Uint8Array before media download to prevent bad decrypt errors

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure mediaKey passed to Baileys download functions is converted from an object to a Uint8Array, preventing bad decrypt errors when using downloadMediaMessage or downloadContentFromMessage.

Sequence diagram for mediaKey conversion before media download

sequenceDiagram
participant Service as BaileysStartupService
participant MediaMsg as mediaMessage
participant Baileys as Baileys download function
Service->>MediaMsg: Check mediaKey type
alt mediaKey is object
    Service->>MediaMsg: Convert mediaKey to Uint8Array
end
Service->>Baileys: Call downloadMediaMessage/downloadContentFromMessage with converted mediaKey
Loading

Class diagram for mediaKey handling in BaileysStartupService

classDiagram
class BaileysStartupService {
  +downloadMediaMessage(msg)
  +downloadContentFromMessage(msg)
}
class mediaMessage {
  mediaKey: object | Uint8Array
}
BaileysStartupService --|> mediaMessage: uses
BaileysStartupService : converts mediaKey from object to Uint8Array
Loading

File-Level Changes

Change Details Files
Convert mediaKey from object to Uint8Array
  • Replace JSON deep clone fallback with direct mediaKey assignment
  • Use Uint8Array.from(Object.values(mediaKey)) for conversion
src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts

Possibly linked issues

  • Docker folder is deleted #1: The PR converts mediaKey to Uint8Array, resolving the 'Message not found' error in getBase64FromMediaMessage by correctly processing media keys.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@KokeroO
Copy link
Contributor

KokeroO commented Sep 17, 2025

Boa. Apliquei aqui. Entrei 100 mil mensagens tenho umas 10 dessas por dia. Irei acompanhar aqui e amanha darei um retorno.

@DavidsonGomes DavidsonGomes merged commit 5a39f1a into EvolutionAPI:develop Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants