Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Based on experimentation with mkl_fft, switching from using "windows-latest" image to "windows-2019" fixes MS compiler use for Python packages.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented May 17, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.971%. remained the same
when pulling 541f5ae on use-windows-2019
into ee1ee10 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_2 ran successfully.
Passed: 890
Failed: 15
Skipped: 91

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows builds are working so LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 9df040a into master May 17, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-windows-2019 branch May 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants