Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Add dpctl.SyclDevice.has_aspect_emulated now that DPC++ supports it, see gh-292

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented May 22, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_14 ran successfully.
Passed: 889
Failed: 16
Skipped: 91

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.943% (-0.03%) from 87.971%
when pulling 09b3c80 on add-emulated-aspect
into 183bfd7 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_16 ran successfully.
Passed: 889
Failed: 16
Skipped: 91

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4a06eb1 into master May 22, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-emulated-aspect branch May 22, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants