Skip to content

Support CMAKE_BUILD_TYPE=Coverage and use it in gen_coverage.py #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oleksandr-pavlyk merged 1 commit into from
May 28, 2024
Merged

Support CMAKE_BUILD_TYPE=Coverage and use it in gen_coverage.py #1692

oleksandr-pavlyk merged 1 commit into from
May 28, 2024

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented May 22, 2024

CMAKE_BUILD_TYPE=Debug is set to allow full debugging information on host (-ggdb3), but no debug information on device for spir64 target

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Support CMAKE_BUILD_TYPE=Coverage and use it in gen_coverage.py
68c6879 
CMAKE_BUILD_TYPE=Debug is set to allow full debugging information
on host (-ggdb3), but no debug information on device for spir64 target
@github-actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented May 22, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_8 ran successfully.
Passed: 889
Failed: 16
Skipped: 91

@coveralls
Copy link
Collaborator

coveralls commented May 22, 2024

Coverage Status

coverage: 87.971%. remained the same
when pulling 68c6879 on add-coverage-build-type
into 183bfd7 on master.

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review May 22, 2024 21:59
ndgrigorian
ndgrigorian approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage works so LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1de00cb into master May 28, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-coverage-build-type branch May 28, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@ZzEeKkAa ZzEeKkAa Awaiting requested review from ZzEeKkAa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @ndgrigorian