Fixes _from_input_shape_strides not validating order in all paths
#1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_90 ran successfully. |
Collaborator
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_91 ran successfully. |
antonwolfy
approved these changes
Jul 10, 2024
Collaborator
There was a problem hiding this comment.
I've checked with dpnp tests and all of them are passing with that PR.
The initial issue is also resolved.
Thank you @ndgrigorian for implementing the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
ordervalidation to the start of_from_input_shape_stridesto guarantee it's valid even if unused.Closes #1724