Skip to content

Fix gh 1744 clip out of bounds scalars #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oleksandr-pavlyk merged 2 commits into from
Jul 29, 2024
Merged

Fix gh 1744 clip out of bounds scalars #1759

oleksandr-pavlyk merged 2 commits into from
Jul 29, 2024

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Jul 25, 2024

Resolves gh-1744

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Resolve gh-1744
c5e6acb 
Applied suggested changes to replace Python min/max ints which are out
of bounds for array integral data type with None.
@oleksandr-pavlyk
Add test based on code from gh-1744
635dc84 
Add test to verify that Python scalars used for min/max
which are out of bound for array integral data type get
handled as None (no bounds).
@github-actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Jul 25, 2024

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_166 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jul 25, 2024

Coverage Status

coverage: 87.973% (+0.008%) from 87.965%
when pulling 635dc84 on fix-gh-1744-clip-out-of-bounds-scalars
into f83f95b on master.

antonwolfy
antonwolfy reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dpnp tests pass with the change without any issue.

ndgrigorian
ndgrigorian approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit fbdd634 into master Jul 29, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-gh-1744-clip-out-of-bounds-scalars branch July 29, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix clip for Numpy 2.0

4 participants

@oleksandr-pavlyk @coveralls @ndgrigorian @antonwolfy