Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

This PR ports commits from gh-1763 to main branch.

This would get changes to support developing dpctl on Windows with NumPy 2.0 in faster than gh-1760 gets merged.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Introduced default_device_uint_type, parallel to
default_device_int_type.

For NumPy >= 2 (as checked at runtime), it returns "i8" (since dpctl
is only supported on x86_64) or unsigned "u8", while for NumPy < 2 it
returns long ("l"), or 'unsigned long' ("L").
@github-actions
Copy link

github-actions bot commented Jul 30, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.609%. remained the same
when pulling 688254c on separate-pr-1763
into 7b64374 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_188 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk changed the title Separate pr 1763 Separate changes in pr 1763 from changes in pr 1760 Jul 30, 2024
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit a40263d into master Jul 30, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the separate-pr-1763 branch July 30, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants