Drop use of soversion for dpctl sycl interface #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
force-pushed
the
drop-use-of-soversion-for-DPCTLSyclInterface
branch
from
cb4286d to
8733570
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_194 ran successfully. |
Library SOVersioning is used to allow libraries of different versions to coexist in the same layout. Since libDPCTLSyclInterface library is being installed into site-packages/dpctl, and since Python does not support multiple versions of the same package installed, such a situation where SOVersioning is required never arises. SOVersioning causes creation of symbolic links which are not supported by Python wheels (symbolic links are followed and 3 hard identical copies of the library are bing created) and only cause wheel size to be overinflated. With all this said, it is better to not set VERSION/SOVERSION target property.
The test would still pass when it is turned back on and symbolic links are present.
oleksandr-pavlyk
force-pushed
the
drop-use-of-soversion-for-DPCTLSyclInterface
branch
from
3bd48d3 to
1364ec4
Compare
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_198 ran successfully. |
ndgrigorian
approved these changes
Aug 1, 2024
ZzEeKkAa
approved these changes
Aug 2, 2024
oleksandr-pavlyk
deleted the
drop-use-of-soversion-for-DPCTLSyclInterface
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns off SOVERSION-ing of libDPCTLSyclInterface
Library SOVersioning is used to allow libraries of different versions
to coexist in the same layout. Since libDPCTLSyclInterface library
is being installed into site-packages/dpctl, and since Python does
not support multiple versions of the same package installed, such a
situation where SOVersioning is required never arises.
SOVersioning causes creation of symbolic links which are not supported
by Python wheels (symbolic links are followed and 3 hard identical
copies of the library are bing created) and only cause wheel size
to be overinflated.
With all this said, it is better to not set VERSION/SOVERSION
target property.