Replace sycl::free with sycl_free_noexcept #1797
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_282 ran successfully. |
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
In general this is a good change, but offset_utils seems like an unintuitive place to put it. I'm not sure where else it would belong though...
|
@ndgrigorian Is |
I think that makes more sense. |
Add implementation of dpctl::tensor::alloc_utils::sycl_free_noexcept that calls sycl::free from within try/catch. The exception is logged to std::cerr, but otherwise ignored.
oleksandr-pavlyk
force-pushed
the
sycl-free-noexcept
branch
from
429bdbc to
3dd4469
Compare
|
@ndgrigorian I created |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_305 ran successfully. |
3 participants
Replace
sycl::freewithsycl_free_noexcept.Add implementation of
dpctl::tensor::offset_utils::sycl_free_noexcepttemplated function that callssycl::freefrom within try/catch. The exception is logged tostd::cerr, but otherwise ignored.Replaced calls to
sycl::freeinhost_taskwith use ofsycl_free_noexcept.This change should improve stability of test suite run executed on CPU device due to a known issue.