Fix issues for numpy 2.1.0 #1804

oleksandr-pavlyk · 2024-08-19T17:36:21Z

Fixed test_full_gh_1230 to work with NumPy 2.1.0.

Fixed dpt.from_dlpack by handling ValueError possibly raised by ndarray.__dlpack__ when its dl_device
keyword argument is unsupported.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

dpctl/tests/test_usm_ndarray_ctor.py

github-actions · 2024-08-19T18:10:20Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2024-08-19T18:15:15Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_329 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

coveralls · 2024-08-19T18:16:41Z

coverage: 87.901% (-0.009%) from 87.91%
when pulling 5e6271d on fix-issues-for-numpy-2.1.0
into 1e52918 on master.

github-actions · 2024-08-19T22:58:28Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_331 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

ndgrigorian · 2024-08-20T00:42:04Z

@oleksandr-pavlyk
Unfortunately, it seems that changing _to_scalar has exposed some other, subtle overflows in other tests.

github-actions · 2024-08-20T12:35:52Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_333 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-08-20T13:53:13Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_334 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-08-20T14:52:58Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_336 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-08-20T17:39:11Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_338 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-08-20T18:55:42Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_337 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

NumPy 2.1.0 now raises exception when fill_value is not in bounds for the array data type. Rework the logic of the test to accomodate that. The test continue to work with NumPy 2.0.1

NumPy 2.1.0 supports DLPack 1.0 now, and raises ValueError if __dlpack__ method gets unsupport dl_device value. Function from_dlpack now handles ValueError, the same way as it handles BufferError

This relies on NumPy to raise OverflowError if the object can not be represented by requested data type.

…ral fill values It should raise OverflowError, like NumPy 2 does.

For 2.0.0 and later, it is to raise OverflowError, otherwise it is expected to wrap up the out-of-bounds integral fill-in values given as Python scalars.

Restrict the input size to allow math the test relies on to work without using out-of-bounds Python scalar inputs to tensor.arange

Change the test so that input matrices that get multiplied only have blocks of ones no larger than the max integer for the type, rest is populated with zeros. This change applies to integral types only.

Use Python 3.12, install recent NumPy (instead of 1.25), update gtest from 1.13 to 1.15.2

github-actions · 2024-08-20T19:38:26Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_339 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

github-actions · 2024-08-20T22:26:48Z

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_340 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

ndgrigorian

Tests are back to passing, LGTM!

oleksandr-pavlyk requested a review from ndgrigorian as a code owner August 19, 2024 17:36

ndgrigorian reviewed Aug 19, 2024

View reviewed changes

dpctl/tests/test_usm_ndarray_ctor.py Outdated Show resolved Hide resolved

oleksandr-pavlyk force-pushed the fix-issues-for-numpy-2.1.0 branch from 16e6c1e to f29e335 Compare August 20, 2024 13:13

oleksandr-pavlyk force-pushed the fix-issues-for-numpy-2.1.0 branch from 7265cef to 881675e Compare August 20, 2024 18:14

oleksandr-pavlyk added 10 commits August 20, 2024 13:59

Correct test_full_gh_1230 for NumPy 2.1.0

6e81050

NumPy 2.1.0 now raises exception when fill_value is not in bounds for the array data type. Rework the logic of the test to accomodate that. The test continue to work with NumPy 2.0.1

Adapt from_dlpack to NumPy 2.1.0 behavior

845382d

NumPy 2.1.0 supports DLPack 1.0 now, and raises ValueError if __dlpack__ method gets unsupport dl_device value. Function from_dlpack now handles ValueError, the same way as it handles BufferError

Convert object for fill_value using asarray for requested type

1c17c34

This relies on NumPy to raise OverflowError if the object can not be represented by requested data type.

Check that full(shape, fill_val, dtype=dt) handles out of bound integ…

abfee14

…ral fill values It should raise OverflowError, like NumPy 2 does.

test_full_gh_1230 to be have differently dependending on NumPy version

a53ca06

For 2.0.0 and later, it is to raise OverflowError, otherwise it is expected to wrap up the out-of-bounds integral fill-in values given as Python scalars.

Fix test_create_program_from_source to not use out-of-bounds fill-value

f441f01

Restrict the input size to allow math the test relies on to work without using out-of-bounds Python scalar inputs to tensor.arange

Fix test_matmul_simple to avoid use of out-of-bounds Python scalars

032ceca

Change the test so that input matrices that get multiplied only have blocks of ones no larger than the max integer for the type, rest is populated with zeros. This change applies to integral types only.

Pin setuptools to <72.2 in hope to fix test_examples_linux workflow

2be4989

Use Python 3.12 to run OS LLVM workflow

7c461f1

Update components in collect coverage

04f8a4c

Use Python 3.12, install recent NumPy (instead of 1.25), update gtest from 1.13 to 1.15.2

oleksandr-pavlyk force-pushed the fix-issues-for-numpy-2.1.0 branch from 881675e to 04f8a4c Compare August 20, 2024 18:59

Be forgiving for test_fill_gh_1230 with older numpy versions

5e6271d

ndgrigorian approved these changes Aug 21, 2024

View reviewed changes

oleksandr-pavlyk merged commit 4297fef into master Aug 21, 2024

oleksandr-pavlyk deleted the fix-issues-for-numpy-2.1.0 branch August 21, 2024 00:48

Fix issues for numpy 2.1.0 #1804

Fix issues for numpy 2.1.0 #1804

Uh oh!

Conversation

oleksandr-pavlyk commented Aug 19, 2024

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2024

Uh oh!

coveralls commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2024

Uh oh!

ndgrigorian commented Aug 20, 2024

Uh oh!

github-actions bot commented Aug 20, 2024

Uh oh!

github-actions bot commented Aug 20, 2024

Uh oh!

github-actions bot commented Aug 20, 2024

Uh oh!

github-actions bot commented Aug 20, 2024

Uh oh!

github-actions bot commented Aug 20, 2024

Uh oh!

github-actions bot commented Aug 20, 2024

Uh oh!

github-actions bot commented Aug 20, 2024

Uh oh!

ndgrigorian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Aug 19, 2024 •

edited

Loading

coveralls commented Aug 19, 2024 •

edited

Loading