Do not push_back compute event to host_tasks list #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is even though sequence of tasks represented by dot_ev does contain host_task to manage temporary USM allocations.
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_342 ran successfully. |
Collaborator
Collaborator
These are the files where we add compute events to our vectors of host tasks. It may be worth removing them as well. |
Fix two additional instances pointed out by @ndgrigorian during PR review.
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_351 ran successfully. |
…ts-in-host-task-lists Fix additional compute events added to lists of host tasks
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_356 ran successfully. |
oleksandr-pavlyk
deleted the
dont-add-compute-event-into-host-task-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not push_back compute event to host_tasks list.
This is even though sequence of tasks represented by dot_ev does contain host_task to manage temporary USM allocations.