Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

This adds an optimization to save rows/cols of sub-matrices stored in SLM into registers prior to summing over delta_m, delta_n and updating private result with products.

This does not make any difference in performance of the compiled code though due to compiler optimization being effective as loops are unrolled, but makes compiler's job easier and the intent clearer.

  • I verified that compiler output for the kernel with this change is identical to the output before it (checked on Intel Max GPU).
  • I checked that code compiles for CUDA backend and test suite run is green

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

This does not make any difference in performance due to compiler
optimization being effective as loops are unrolled, but makes compiler's
job easier and the intent clearer.
@github-actions
Copy link

github-actions bot commented Aug 23, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_348 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_348 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.903%. remained the same
when pulling af82129 on tweak-to-gemm
into cfba263 on master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6cab90c into master Aug 23, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the tweak-to-gemm branch August 23, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants