Fix a regression in the API CompletionCompleters.CompleteFilename() that causes null reference exception
#26291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null reference exception in the CompletionCompleters.CompleteFilename() API that occurs when RelatedAsts is null. The fix adds null-conditional operators to safely handle cases where the API is called directly without a completion context containing related ASTs.
- Added null-conditional operators to prevent null reference exceptions when
RelatedAstsis null - Added test coverage for calling
CompleteFilename()directly with an empty string
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs | Added null-conditional operators to safely access RelatedAsts and its elements |
| test/powershell/Host/TabCompletion/BugFix.Tests.ps1 | Added test case to verify CompleteFilename() works when called directly without null reference exceptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
13 tasks
daxian-dbw
added
CL-General
TravisEz13
approved these changes
Oct 23, 2025
Contributor
|
📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 19, 2025
… that causes null reference exception (PowerShell#26291)
9 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
… that causes null reference exception (PowerShell#26291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #26277
The
RelatedAstsvalue isnullwhen callingCompletionCompleters.CompleteFilename()directly. This PR fixes the code to handle that case.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header