Skip to content

Conversation

@TravisEz13
Copy link
Member

Update the macos package name for preview releases to match the previous pattern.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the macOS package naming convention for preview releases. Instead of using powershell-preview-X.Y.Z-preview.N pattern, preview packages now follow the same pattern as stable releases (powershell-X.Y.Z-preview.N), where the preview designation is indicated solely by the version string rather than the package name prefix.

Key Changes

  • Removed the elseif ($IsPreview) branch that added -preview to package names for non-LTS preview builds
  • Updated regex patterns in test and validation files to match the new naming convention (removing preview as a name prefix option)
  • Clarified comments to explain that preview/rebuild versions are identified by the version string itself

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tools/packaging/packaging.psm1 Removed logic that added -preview prefix to package names for preview releases
test/packaging/macos/package-validation.tests.ps1 Updated regex pattern and comments to validate new naming convention
.pipelines/templates/release-validate-packagenames.yml Updated regex pattern to remove (osx\.10\.12)? legacy pattern and align with new naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 12, 2025
@TravisEz13 TravisEz13 merged commit 4aa65a7 into PowerShell:master Nov 12, 2025
38 of 39 checks passed
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Nov 12, 2025
…ous pattern (PowerShell#26429)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Dec 2, 2025
…ous pattern (PowerShell#26429)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Dec 5, 2025
Update test/packaging/macos/package-validation.tests.ps1 with correct regex pattern
for macOS package naming validation. This file was missed in the original backport
PR PowerShell#26562.

Changes:
- Remove (-preview|-lts)? pattern (no more -preview in names)
- Update to (lts-)? - only LTS gets prefix
- Update comments to reflect new naming convention
- Match validation used in release-validate-packagenames.yml
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
…ous pattern (PowerShell#26429)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Migrated BackPort-7.5.x-Consider Backport-7.6.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants