-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update the macos package name for preview releases to match the previous pattern #26429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the macos package name for preview releases to match the previous pattern #26429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the macOS package naming convention for preview releases. Instead of using powershell-preview-X.Y.Z-preview.N pattern, preview packages now follow the same pattern as stable releases (powershell-X.Y.Z-preview.N), where the preview designation is indicated solely by the version string rather than the package name prefix.
Key Changes
- Removed the
elseif ($IsPreview)branch that added-previewto package names for non-LTS preview builds - Updated regex patterns in test and validation files to match the new naming convention (removing
previewas a name prefix option) - Clarified comments to explain that preview/rebuild versions are identified by the version string itself
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/packaging/packaging.psm1 | Removed logic that added -preview prefix to package names for preview releases |
| test/packaging/macos/package-validation.tests.ps1 | Updated regex pattern and comments to validate new naming convention |
| .pipelines/templates/release-validate-packagenames.yml | Updated regex pattern to remove (osx\.10\.12)? legacy pattern and align with new naming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ous pattern (PowerShell#26429) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ous pattern (PowerShell#26429) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update test/packaging/macos/package-validation.tests.ps1 with correct regex pattern for macOS package naming validation. This file was missed in the original backport PR PowerShell#26562. Changes: - Remove (-preview|-lts)? pattern (no more -preview in names) - Update to (lts-)? - only LTS gets prefix - Update comments to reflect new naming convention - Match validation used in release-validate-packagenames.yml
…ous pattern (PowerShell#26429) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update the macos package name for preview releases to match the previous pattern.