Skip to content

Conversation

@TravisEz13
Copy link
Member

Backport of #26290 to release/v7.6

Triggered by @TravisEz13 on behalf of @daxian-dbw

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Fixes Start-PSBuild to correctly handle ready-to-run compilation based on configuration. Previously Debug builds incorrectly enabled ready-to-run, making debugging impossible. This fix ensures developers can properly debug PowerShell on release/v7.6 branch.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Original PR verified that Start-PSBuild correctly enables ready-to-run only for Release configuration. Backport tested by:

  1. Building with Debug configuration and confirming ready-to-run is disabled
  2. Building with Release configuration and confirming ready-to-run is enabled
  3. Verifying debugging capability works in Debug builds

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Medium risk: Changes build configuration properties that affect all deployments (FxDependentDeployment and SelfContained). The change is well-scoped to only add Configuration conditions, preserving existing behavior for Release builds while fixing Debug builds. Has been validated in master branch.

Copilot AI review requested due to automatic review settings November 18, 2025 23:50
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 18, 2025
@TravisEz13 TravisEz13 requested a review from a team as a code owner November 18, 2025 23:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports a build configuration fix from the main branch (#26290) to release/v7.6. The fix ensures that ready-to-run compilation is only enabled for Release builds, preventing Debug builds from being unusable for debugging purposes.

Key Changes:

  • Split PropertyGroup conditions to separate AppDeployment and Configuration checks
  • Add explicit Configuration=='Release' conditions for PublishReadyToRun settings
  • Affects both FxDependentDeployment and SelfContained build configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TravisEz13 TravisEz13 merged commit 46f219c into PowerShell:release/v7.6 Nov 19, 2025
40 of 42 checks passed
@TravisEz13 TravisEz13 deleted the backport/release/v7.6/26290-b0507ca4c branch November 19, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants