[release/v7.6] Make the experimental feature PSFeedbackProvider stable
#26502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
added
the
CL-General
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports the graduation of the PSFeedbackProvider experimental feature to stable status in the release/v7.6 branch. It removes the experimental feature flag and completely eliminates the legacy suggestion framework, making the extensible feedback provider system the default implementation for providing user suggestions in PowerShell.
Key Changes:
- Removed
PSFeedbackProviderfrom the experimental features list and associated constant - Eliminated the conditional check between feedback provider and legacy suggestion systems
- Deleted the entire legacy suggestion framework including
GetSuggestionmethods,SuggestionMatchTypeenum, and related infrastructure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs | Removed PSFeedbackProvider constant and its registration from the experimental features list while preserving v7.6-specific experimental features |
| src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs | Removed experimental feature check and legacy EvaluateSuggestions method, now always using EvaluateFeedbacks |
| src/System.Management.Automation/engine/hostifaces/HostUtilities.cs | Deleted legacy suggestion framework including GetSuggestion methods, SuggestionMatchType enum, and all supporting code |
| src/System.Management.Automation/resources/SuggestionStrings.resx | Removed obsolete resource strings for legacy suggestion system |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft-github-policy-service
bot
added
the
Waiting on Author
daxian-dbw
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26343 to release/v7.6
Dependencies
This PR depends on #26490 being merged first.
PR #26490 backports prerequisite changes that this PR builds upon. Please review and merge #26490 before merging this PR.
Triggered by @TravisEz13 on behalf of @daxian-dbw
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
This makes the PSFeedbackProvider experimental feature stable by removing it from the experimental features list and removing the old suggestion framework. This is a customer-facing change as it affects how feedback/suggestions are presented to users in the console.
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Original PR was tested on master branch. Backport verified by successfully resolving merge conflicts while preserving v7.6-specific experimental features, cherry-pick completed successfully, and 4 files changed with clean removal of deprecated code.
Risk
REQUIRED: Check exactly one box.
This is a feature graduation that has been approved by PMs and maintainers. The PSFeedbackProvider feature has been tested as experimental and is now being made stable. The old suggestion framework removal is a cleanup of deprecated code. The conflicts were straightforward - preserving v7.6 experimental features while removing PSFeedbackProvider.
Merge Conflicts
Conflicts occurred in 2 files during cherry-pick:
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
src/System.Management.Automation/engine/hostifaces/HostUtilities.cs