tools(phpcs): remove conflicting TypeHint rules from PHPCS ruleset. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #15 +/- ##
========================================
Coverage ? 90.64%
Complexity ? 102
========================================
Files ? 7
Lines ? 556
Branches ? 0
========================================
Hits ? 504
Misses ? 52
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gziolo
approved these changes
Aug 14, 2025
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Makes sense to start with less strict rules.
Member
|
All checks are required now. I enabled auto-merge 🎉 |
gziolo
added
[Type] Bug
Contributor
Author
Love that we can but ps this makes me want to prefix/namespace even more 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes unnecessary and conflicting PHPCS rules regarding Type Hints and signatures.
Why
Part of #13
I was over optimistic at seeing them used in
WordPress/performance, but as it's getting in the way there's no need to include them.What's important can be caught in code review or in follow up PRs before merge.