Skip to content

Conversation

@Rajinsharwar
Copy link

Using the 'paged' var if the singular page is the front page with unit tests

Trac ticket: https://core.trac.wordpress.org/ticket/50163


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Apr 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rajinsharwar, peterwilsoncc, mukesh27, hellofromtonya.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request looks good to me.

@Rajinsharwar I took the liberty of merging in trunk and adding a second test to make sure this doesn't affect sites using the blog archive on the home page.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Source code changes align to the original changes in PR #270
  • Has unit tests ✅
  • Running unit tests locally:
    • npm run test:php tests pass ✅
    • with -- --group canonical tests pass ✅
    • with -- --group 50163 tests pass ✅
    • with -- --filter Tests_Canonical_Paged tests pass ✅
  • Manual testing in local browser works as expected and resolves the bug:

LGTM for commit 👍

@hellofromtonya
Copy link
Contributor

@hellofromtonya
Copy link
Contributor

Reopening as r59091 was reverted by https://core.trac.wordpress.org/changeset/59133.

Why? It caused a BC break for a static homepage that includes a shortcode's or block's with paginated content that uses the 'paged' query var, e.g. bbPress (details are here in the Trac ticket).

Resetting the PR approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants