Skip to content

Conversation

@costdev
Copy link
Contributor

@costdev costdev commented Jul 29, 2024

This implements the new wp_get_wp_version() helper function to get the unmodified WordPress version for compatibility checks.

A new global, _wp_tests_wp_version has been introduced to allow for testing against different "current" WordPress versions.

Trac ticket: https://core.trac.wordpress.org/ticket/61781

@costdev costdev force-pushed the use-wp_get_wp_version-in-is_wp_version_compatible branch from 7797355 to 5de49c1 Compare July 29, 2024 00:44
@costdev costdev changed the title Use wp_get_wp_version() in is_wp_version_compatible(). Plugins: Use wp_get_wp_version() in is_wp_version_compatible(). Jul 29, 2024
@costdev costdev force-pushed the use-wp_get_wp_version-in-is_wp_version_compatible branch 4 times, most recently from 15ac5f0 to d76954d Compare July 29, 2024 00:49
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@costdev costdev marked this pull request as ready for review July 29, 2024 01:05
@github-actions
Copy link

github-actions bot commented Jul 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props costdev, peterwilsoncc, mukesh27, sergeybiryukov.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@costdev costdev force-pushed the use-wp_get_wp_version-in-is_wp_version_compatible branch from d76954d to a2e69ce Compare July 29, 2024 01:24
@costdev costdev requested a review from peterwilsoncc July 29, 2024 01:30
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks Colin.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

@peterwilsoncc peterwilsoncc added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Aug 2, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Aug 2, 2024
@peterwilsoncc
Copy link
Contributor

Merged r58843 / 0e06e2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants