-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Plugins: Use wp_get_wp_version() in is_wp_version_compatible().
#7104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Use wp_get_wp_version() in is_wp_version_compatible().
#7104
Conversation
7797355 to
5de49c1
Compare
wp_get_wp_version() in is_wp_version_compatible().wp_get_wp_version() in is_wp_version_compatible().
15ac5f0 to
d76954d
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
d76954d to
a2e69ce
Compare
peterwilsoncc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks Colin.
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
This implements the new
wp_get_wp_version()helper function to get the unmodified WordPress version for compatibility checks.A new global,
_wp_tests_wp_versionhas been introduced to allow for testing against different "current" WordPress versions.Trac ticket: https://core.trac.wordpress.org/ticket/61781