14110 - Expose height and width attributes to 'wp_get_attachment_image_attributes' filter #8758
Conversation
Added validation to sanitize 'width' and 'height' attributes before use and updated the default attributes accordingly. This improves security and prevents potential issues with invalid values in generated image markup.
Simplified the code by directly passing `$attr` instead of creating and assigning a redundant `$loading_attr` array. This improves readability and eliminates unnecessary variable usage while maintaining functionality.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Refactored the handling of `height` and `width` attributes by storing their sanitized values in separate variables before unsetting them. This aims to improve code readability and maintainability.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Previously, the height and width attributes were directly sanitized using `absint`, which could lead to unexpected behavior if non-numeric values were passed. This update adds a check to confirm the values are numeric before sanitizing, improving data validation and preventing potential errors.
Consolidated logic for processing height and width attributes by combining conditions and reducing redundant checks. Unset operations for these attributes are now grouped for clarity. This improves code readability and maintainability.
adamsilverstein
left a comment
adamsilverstein
left a comment
There was a problem hiding this comment.
Looks great! One small question.
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@spacedmonkey Mostly looks good to me, except it would be safer to modify the $attr array directly.
Ensured `width` and `height` attributes are always set in the final `$attr` array for consistent handling of image dimensions. Improved code readability by aligning array keys.
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@spacedmonkey Production code looks good.
Would be great to add a test case where the width and/or height are modified via filter, to ensure this actually works.
jonnynews
force-pushed
the
fix/height-width
branch
from
afc4ef8 to
d956be4
Compare
Introduced tests to validate the behavior of `wp_get_attachment_image_attributes` filter, ensuring proper handling of `width` and `height` attributes. Includes tests for default values, modified values, and unset scenarios to ensure consistent attribute handling.
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/14110
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.