Skip to content

Backport: add support for selects on the elements API #8961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaggieCabrera wants to merge 2 commits into from
Closed

Backport: add support for selects on the elements API #8961

MaggieCabrera wants to merge 2 commits into from

Conversation

@MaggieCabrera
Copy link

@MaggieCabrera MaggieCabrera commented Jun 11, 2025 •
edited by mikachan
Loading

Backport for WordPress/gutenberg#70379

Trac ticket: https://core.trac.wordpress.org/ticket/63555

What?

Part of WordPress/gutenberg#34198

This PR adds support for the select element which can be used by themers and extenders to style selects or dropdown elements. Right now the experimental form block doesn't have dropdowns in it, but many extenders do, so I wanted to cover them too in line with the work being done at #70378

Why?

So a theme can style consistently how forms should look like regardless of the plugins installed (if they opt in this new API)

How?

We are targeting the select HTML element instead of adding a class, more context in this comment about the reasoning. In any case, this PR adds no extra styling unless a theme opts in to use this and the specificity of any generated CSS with the element would be 0.

Testing Instructions

This one is a little hard to test without having a native block that has a dropdown in it that doesn't overly style it. What I did was:

  1. added the following to my theme.json file:
"elements": {
			"select": {
				"color": {
					"text": "red",
					"background": "blue"
				}
			},
}
  1. With WooCommerce active I checked any selects added by the plugin that don't have styles for text or background.
Screenshot 2025-06-10 at 16 32 33

Trac ticket:

https://core.trac.wordpress.org/ticket/63555

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props onemaggie, scruffian.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jun 11, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions github-actions bot mentioned this pull request Oct 16, 2025
Closed
@scruffian scruffian force-pushed the add-select-elements-support branch from dbc76a6 to 8d794d1 Compare October 21, 2025 08:42
scruffian
scruffian approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@scruffian scruffian force-pushed the add-select-elements-support branch from 8d794d1 to 079ca78 Compare October 21, 2025 09:32
@mikachan mikachan force-pushed the add-select-elements-support branch from 079ca78 to 35395aa Compare October 21, 2025 11:59
@scruffian scruffian force-pushed the add-select-elements-support branch from 35395aa to ec9e669 Compare October 21, 2025 12:43
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61031
GitHub commit: 2bc0982

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scruffian scruffian scruffian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaggieCabrera @scruffian