Allow Php8.5 Support #122
Allow Php8.5 Support #122
Conversation
|
|
delatrie
left a comment
delatrie
left a comment
There was a problem hiding this comment.
Hi, @sandesh-as ! Thank you for your contribution.
We need to fix the pipeline before going further. Please review my comment.
sandesh-as
force-pushed
the
Php-8.5-support
branch
from
9643719 to
6b75193
Compare
|
Hi @delatrie, I’ve addressed a few issues that were occurring in the CLI tests. Could you please review the changes and approve the workflow. |
| "phpunit/phpunit": "^10.0.5 || ^11 || ^12.0.1" | ||
| }, | ||
| "require-dev": { | ||
| "amphp/amp": "^3.1.1", |
There was a problem hiding this comment.
We don't use these extra dependencies, so we shouldn't declare them. A better place is to constrain their versions in the include section of the job matrix:
include:
# Some dev libraries are resolved to versions incompatible with PHP 8.5
# under the --prefer-lowest strategy. Here we're constraining them to
# the lowest compatible versions.
- php-version: "8.5"
update-constraints: "'--with=amphp/amp:>=3.1.1' '--with=amphp/parallel:>=2.3.3' '--with=nikic/php-parser:>=5.7' '--with=revolt/event-loop:>=1.0.8'"I'm thinking of giving up the --prefer-lowest testing altogether, since those things are gonna get more and more complex, but let's keep it for now.
| $this->expectNotToPerformAssertions(); | ||
| } | ||
|
|
||
| /** @psalm-suppress InvalidAttribute */ |
There was a problem hiding this comment.
Fixed in psalm 6.14.3. We can remove these comments now.
3 participants
No description provided.