mark top-level symbols as side-effect free #66216
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terser/nor ESBuild do treat Symbol as side-effect free- so if we end up with a symbol export being loaded, it will result in the symbol being retained.
pullapprove
bot
added
the
requires: TGP
Terser/nor ESBuild do treat Symbol as side-effect free- so if we end up with a symbol export being loaded, it will result in the symbol being retained.
SkyZeroZx
force-pushed
the
refactor/mark-as-pure
branch
from
9d2f8ad to
849e57d
Compare
Member
|
esbuild will tree-shake those since the recent 0.27.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks top-level symbols as pure (PATH, ɵCONTROL, NOT_FOUND) to allow proper tree-shaking.
Neither Terser nor esbuild treat
Symbolas side-effect free by default, which causedexported symbols to be retained. This was observed during signals prototyping, where
symbols from
computedappeared in bundling tests.Similar to #51776 and #61312