fix(compiler): stop ThisReceiver inheritance from ImplicitReceiver #66218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: patch
angular-robot
bot
added
the
area: compiler
Member
Author
crisbeto
added
action: review
JoostK
reviewed
Dec 22, 2025
packages/compiler-cli/src/ngtsc/typecheck/template_semantics/src/template_semantics_checker.ts
Outdated
Show resolved
Hide resolved
Back in angular#39323, I added a new `ThisReceiver` node to represent accesses done through `this` and I ended up making it inherit from `ImplicitReceiver`. The logic was that in most cases accessing through `this` was the same as the implicit access. Over the years this has proven to not be a great idea, because no other AST nodes do this and one has to keep it in mind whenever dealing with `ImplicitReceiver`. These changes remove the inheritance and update all of the usage sites accordingly.
crisbeto
force-pushed
the
this-receiver
branch
from
c9bbee1 to
5300248
Compare
JoostK
approved these changes
Dec 22, 2025
crisbeto
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #39323, I added a new
ThisReceivernode to represent accesses done throughthisand I ended up making it inherit fromImplicitReceiver. The logic was that in most cases accessing throughthiswas the same as the implicit access.Over the years this has proven to not be a great idea, because no other AST nodes do this and one has to keep it in mind whenever dealing with
ImplicitReceiver.These changes remove the inheritance and update all of the usage sites accordingly.