refactor(router): Permit deferring commit of traversal navigations #66227
+265
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supported This commit adds a token that indicates whether the precommitHandler feature is supported by the navigation api. https://developer.mozilla.org/en-US/docs/Web/API/NavigateEvent/intercept#precommithandler
…gration The `precommitHandler` of the Navigation API unlocks some of the truly powerful features for Routers like Angular's which defer the URL updates. Without the `precommitHandler`, we cannot initiate a navigation until we are ready to commit the URL because it causes the URL to update immediately. With `precommitHandler` support, we are able to create a `NavigateEvent` _immediately_ on navigation, which allows the browser to show that a navigation is happening with a loading indicator. Site visitors will also have the ability to cancel the navigation with the "stop" button. When we are ready to commit the URL, the precommitHandler supports a "redirect" function that we can use to first redirect the navigation to a new location immediately before committing it. The commit operation is not synchronous because the API waits for all precommitHandlers to resolve. This commit adds a small bit of handling to account for this so that the Router's transition does not advance to the next stage until the URL has been committed.
This builds off of angular#66197 by retaining the original navigateEvent across redirects so the NavigateEvent can more accurately track the lifecycle of a navigation, which may span across several NavigationStart events due to redirects
angular-robot
bot
added
area: common
This updates the state manager to allow intercepting and deferring commits of traversal navigations. The issues that were encountered in the past appear to be resolved in Chrome. The behavior of redirect is still undefined in this case, so there is an added TODO.
atscott
force-pushed
the
deferTraversal
branch
from
7bdfb3d to
fdf8163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the state manager to allow intercepting and deferring commits of traversal navigations.
The issues that were encountered in the past appear to be resolved in Chrome.
The behavior of redirect is still undefined in this case, so there is an added TODO.
Reviewer not: First 3 commits are in other (approved) PRs. Only the last commit is needing review