Support for ActiveMQ-Artemis messaging tracing. #670
Conversation
| 2.30.0 | ||
| 2.31.2 |
There was a problem hiding this comment.
Could we support more versions? I saw versions in the docs are 2.30 and 2.31 only
There was a problem hiding this comment.
for the testcase depends on spring-boot-3.2.0 and artemis-jakarta-client , it can support
- not 2.19.0, and 2.19.0before not tested
- not 2.24.0
- not 2.25.0
- 2.26.0
- 2.27.0
- 2.28.0
- not 2.29.0
- 2.30.0
- 2.31.x
the version not supprt because of the dependency conflicts with SpringBoot, and springboot-stater-artemis officially support 3 versions of Artemis with jakarta-client (2.26.0,2.28.0,2.31.2)
There was a problem hiding this comment.
From you description, I think we should say we support
- Spring Starter Artemis + ActiveMQ-Artemis a/b/c versions
- ActiveMQ-Artemis a/b/c/e/f/g versions.
We should have two test scenarios to cover two version lists.
There was a problem hiding this comment.
artemis-jakarta-client has many minor versions, do the support-list.md have to record all the last version number of each minor version.
There was a problem hiding this comment.
support-list.md should list all the range. support-version.list should pick the latest patch version of every minor for verification. Such as, we could say, we support 2.19 - 2.31, and test 2.19.1 for 2.19.x, 2.23.1 for 2.23.x, 2.31.2 for 2.31.x ...
There was a problem hiding this comment.
It can support all artemis-jakarta-client versions from 2.17.0 to 2.31.2 by running the testcase project, but the official docker image apache/activemq-artemis just provide from 2.30.0,. Can I written support 2.17.0 ~ 2.31.2, and test 2.30.0/2.31.2 in support-list.md?
There was a problem hiding this comment.
Yes, you can put it that way if you have verified locally or have checked from source codes level.
| 2.30.0 | |
| 2.31.2 | |
| # You should put comments here about why others are not tested in the plugin test pipeline. | |
| 2.30.0 | |
| 2.31.2 |
There was a problem hiding this comment.
One more question, Images you provided are server side versions, could you use various client versions to connect 2.31 server?
What we need to verify is only client version compatibility, I believe the server version doesn't matter.
There was a problem hiding this comment.
Ok, I can fix the server version, to check the client version.
Please notice the name. |
|
Please fix the javadoc. Warning is fine, notice the error ones, which should be from your codes. |
|
Is anything wrong for RocketMQ grpc case? |
I try to check again. |
2 participants
Add an agent plugin to support ActiveMQ-Artemis
Add a test case for the new plugin, refer to the doc
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #11830.
Update the
CHANGESlog.