Skip to content

Fix the opentracing toolkit SPI config #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wu-sheng merged 2 commits into from
Jun 6, 2024
Merged

Fix the opentracing toolkit SPI config #696

wu-sheng merged 2 commits into from
Jun 6, 2024
+2 −1

Conversation

@xiaqi1210
Copy link
Contributor

@xiaqi1210 xiaqi1210 commented Jun 6, 2024

Fix

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.
  1. The directory for SPI should be /META-INF/services, not /META-INF.services.
  2. There is an issue with the letter casing in the class name. It should be SkywalkingTracer, not SkyWalkingTracer.

@wu-sheng wu-sheng added this to the 9.3.0 milestone Jun 6, 2024
@wu-sheng wu-sheng added the bug Something isn't working label Jun 6, 2024
wu-sheng
wu-sheng approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK to merge, but, OT is archived over 2 years(since January 31, 2022).

It is the time to get rid of it.

@wu-sheng wu-sheng merged commit 3a96458 into apache:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

9.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@xiaqi1210 @wu-sheng