fix: arrow/async in conditional expressions for TS #17572
Conversation
liuxingbaoyu
changed the title
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60120 |
| if (!this.eat(tt.colon)) { | ||
| state.noArrowAt = this.state.noArrowAt; | ||
| if (state.noArrowAt.length <= 3) { | ||
| state.noArrowAt = [state.noArrowAt[0]]; | ||
| } else { | ||
| state.noArrowAt = state.noArrowAt.slice(3); | ||
| } | ||
| this.state = state; | ||
| node.consequent = this.parseMaybeAssignAllowIn(); | ||
| this.expect(tt.colon); | ||
| } |
There was a problem hiding this comment.
This was inspired by the Flow plugin, thanks to @nicolo-ribaudo.
The current implementation doesn't look reliable at all, but it passes all the tests.🤦♂️
If we try them one by one, it will be more reliable, but slower.
|
commit: |
| @@ -0,0 +1 @@ | |||
| true ? async (): true; | |||
There was a problem hiding this comment.
Although it is valid JavaScript, tsc does not support it either:
https://www.typescriptlang.org/play/?#code/C4JwrgpgBA-FCGBnAngOwMZQBQEoBcUokA3EA
Could we skip this test temporarily and enable it when we align to the tsc behaviour?
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I don;t love this, but it looks ok. It'd be great to see some benchmarks, but we should prioritize correctness over performance anyway.
4 participants
I initially tried to port the TS implementation, but failed.
Maybe I should try again.