Skip to content

fix: Makefile: crash when no condition #17640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
coderaiser wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Makefile: crash when no condition #17640

coderaiser wants to merge 1 commit into from

Conversation

@coderaiser
Copy link
Contributor

@coderaiser coderaiser commented Dec 5, 2025

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

babe-eslint-plugin has no condition, so:

node Makefile.source.mjs new-babel-8-version-create-commit-ci

throws:

file:///Users/coderaiser/babel-babel/Makefile.source.mjs:571
          babel8Condition.peerDependencies["@babel/eslint-parser"] =
                          ^

TypeError: Cannot read properties of undefined (reading 'peerDependencies')
    at file:///Users/coderaiser/babel-babel/Makefile.source.mjs:571:27
    at Array.forEach (<anonymous>)
    at file:///Users/coderaiser/babel-babel/Makefile.source.mjs:559:25
    at Array.forEach (<anonymous>)
    at bumpVersionsToBabel8Pre (file:///Users/coderaiser/babel-babel/Makefile.source.mjs:558:11)
    at target.new-babel-8-version-create-commit-ci (file:///Users/coderaiser/babel-babel/Makefile.source.mjs:587:23)
    at global.target.<computed> [as new-babel-8-version-create-commit-ci] (/Users/coderaiser/babel-babel/node_modules/shelljs/make.js:36:40)
    at /Users/coderaiser/babel-babel/node_modules/shelljs/make.js:48:27
    at Array.forEach (<anonymous>)
    at Timeout._onTimeout (/Users/coderaiser/babel-babel/node_modules/shelljs/make.js:46:10)

Node.js v25.2.1

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 5, 2025

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60396

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 5, 2025

Open in StackBlitz

commit: 9da7749

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 5, 2025

We are in the process of removing Babel 7 from the codebase, I still need to recheck the whole publishing process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coderaiser @babel-bot @nicolo-ribaudo