Fixed confusing parameter name in CNAMERecord #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CNAMERecordclass has a constructor parameter for the CNAME target which is calledaliasat the moment. This is quite confusing, because:CNAMERecord#getAlias()which does NOT return the value supplied with thealiasconstructor parameter, but returns the name of the record instead.I think it would be help to rename this parameter to
target. That is also consistent with the name used inNSRecordandPTRRecord.