Skip to content

Conversation

@Sineaggi
Copy link
Contributor

@Sineaggi Sineaggi commented Jan 10, 2024

With the exclusion as-is, newer versions of apache httpclient fail with ClassNotFoundError.

The main fix here is to avoid subclassing the PlainConnectionSocketFactory, and instead implement the ConnectionSocketFactory interfact directly, delegating to PlainConnectionSocketFactory.INSTANCE where necessary.

Fixes #2290

@Sineaggi Sineaggi changed the title Remove exclusion Remove exclusion and fix httpclient5 compatibility Jan 11, 2024
@Sineaggi Sineaggi marked this pull request as ready for review January 11, 2024 22:13
@Sineaggi Sineaggi requested a review from a team as a code owner January 11, 2024 22:13
@Sineaggi
Copy link
Contributor Author

Rebased, all checks are green.

@eddumelendez
Copy link
Member

The main fix here is to avoid subclassing the PlainConnectionSocketFactory, and instead implement the ConnectionSocketFactory interfact directly, delegating to PlainConnectionSocketFactory.INSTANCE where necessary.

Can you elaborate more on this, please?

@twarner-sofi
Copy link

@eddumelendez According to the maintainers of apache http, PlainConnectionSocketFactory is not meant to be directly subclassed, and they make no API stability guarantees when doing so. See: apache/httpcomponents-client#535 (comment)

@eddumelendez
Copy link
Member

Thanks @twarner-sofi ! useful info 👍🏽

@eddumelendez eddumelendez added this to the next milestone Feb 26, 2024
@eddumelendez eddumelendez merged commit 3514b3b into docker-java:main Feb 26, 2024
@eddumelendez
Copy link
Member

Thanks for your contribution, @Sineaggi !

@Sineaggi Sineaggi deleted the remove-exclusion branch February 26, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

connect docker has error

3 participants