-
Notifications
You must be signed in to change notification settings - Fork 59
Adjust for PyGfx's new ticks #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/tickmarks |
|
Nice! I think keep the both sided ticks |
I mostly created this to update the screenshots due to the new PyGfx 😅, so that the new screenshots in #906 were only for the changes in that pr. But yeah, we should get things merged one way or another. Regarding the screenshots, one thing I don't understand is that that in a screenshots-build like this one, there's two artifacts, which both contain all screenshots that are also in the repo (via LFS). Which one should I pick? BTW: Is the imgui bump in Pygfx / wgpu a problem for FPL? |
So one is supposed to have screenshots that have imgui elements (such as the toolbar), and the other is supposed to have screenshots without imgui elements (to make sure that everything still functions correctly without the optional imgui install). But now I realize that the imgui screenshots still get uploaded even in the non-imgui artifact because they exist in that dir. So in the screenshot regenerate action I should add a
Nope! I updated the fonts changes here: f1746be And now in optional dependencies I let wgpu handle imgui version: Line 60 in 6a0d3b3
I wonder if it would make sense to do this for pygfx too? |
PyGfx does not depend on imgui; only some examples do. |
It's an optional dependency: https://github.com/pygfx/pygfx/blob/37cdd2664020c52380e44fc37c43129882b76f4d/pyproject.toml#L43 Might be better to let wgpu handle it? |
|
Ah, I see what you mean now. Yeah, would be nice to use |
A lot of screenshots in fpl will need to be updated because of this upstream change.
By changing tick_marker and tick_size, we can also get this, let me know what you prefer: