py: REAL type tests for ARG_MAX and ARG_MIN aggregates #3330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
reviewed
Jan 16, 2025
| # checked manually | ||
| self.data = [{"c1": Decimal("57681.18"), "c2": Decimal("873315.8")}] | ||
| self.sql = """CREATE MATERIALIZED VIEW real_arg_max AS SELECT | ||
| RF(ARG_MAX(c1, c2)) AS c1, |
Contributor
There was a problem hiding this comment.
No need to use RF for DECIMAL, only for REAL tests.
In fact, something is fishy here, since the result is a DECIMAL, and it should be a REAL if you call RF.
Contributor
Author
There was a problem hiding this comment.
In fact, something is fishy here, since the result is a DECIMAL, and it should be a REAL if you call RF.
@mihaibudiu since #3241 documents this edge case, we should be able to move forward with this PR. Please approve if you agree.
Contributor
There was a problem hiding this comment.
this is wrong, I will file an issue.
Contributor
|
what is the status of this PR? |
Signed-off-by: rivudhk <rivudhkr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.