[WebConsole] Fix page sometimes goes blank on high-throughput change stream #4102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karakatiza666
added
bug
…stream Fix header disappearing at the top of a long change stream Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Contributor
I don't understand what this means In any case, this general code area has been a recurring problem zone riddled with bugs it would be good to find out if there are any standard/simple solutions we're missing for this |
gz
approved these changes
Jun 3, 2025
Contributor
Author
|
{ "foo": "foo", "bar": "bar" } -> { "foobar": "bar" } |
Contributor
Author
|
I observe reduced perceived performance of change stream updates, I want to do another pass on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix header disappearing at the top of a long change stream
The cause of the issue going blank was due to the way backpressure relief when parsing high-throughput change stream JSON was implemented. Previously when backpressure occurred new cunks of data were simply discarded, but the parsing was re-attempted; usually skipping chunks of json string caused parsing to fail immediately, but sometimes dropping chunks results in a syntactically valid, but structurally invalid JSON, so the parsing succeeded, but the result values were unpredictable. These events caused UI to crash as malformed JSON objects propagated in the UI.
The fix is to re-start parsing when backpressure was relieved by dropping chunks of the stream