-
Notifications
You must be signed in to change notification settings - Fork 89
[RFC] Add ability to declare unit tests in udf.rs #4922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8993061 to
9ba6b57
Compare
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
9ba6b57 to
5162e0c
Compare
|
You can make the point with a much smaller example. |
|
That's the example I was working on, did not want to spend time to provide a minimal example just for the PR. |
|
Test failures are displayed in the "Errors" tab and allow navigating to the LOC of the test assertion, but do not prevent starting up the pipeline |
|
So the Rust unit tests run every time the pipeline is recompiled? |
|
Yes |
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
|
For the sake of an argument I have added a udf_checksum to avoid re-running UDF tests if UDF-related code has not changed |
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
|
@Karakatiza666 Is this ready for review? |
|
I need more feedback on this. I believe @gz had a consideration that the debug symbols would get included into compiled dependencies of a production pipeline? |
Compilation error in the test module, or the test failures do not prevent starting the pipeline.
You can use the following pipeline to test the feature:
program.sql
udf.rs
udf.toml
Ad-hoc insert statement: