[WebConsole] Add a Bun version check to prevent building with unsupported version #5237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Bun version check to prevent building with unsupported versions and updates the support bundle filename to be more descriptive. The version check script ensures developers use Bun 1.3.3 or higher before running dev or build commands.
Key Changes:
- Added automated Bun version validation (minimum 1.3.3) that runs before dev/build
- Updated support bundle filename from
fda-bundle-*tofeldera-support-bundle-*
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
js-packages/web-console/scripts/check-bun-version.ts |
New script that validates Bun version against minimum requirement (1.3.3) |
js-packages/web-console/package.json |
Integrated version check into dev and build npm scripts |
js-packages/web-console/src/lib/compositions/usePipelineManager.svelte.ts |
Updated downloaded support bundle filename prefix |
| @@ -0,0 +1,32 @@ | |||
| #!/usr/bin/env bun | |||
There was a problem hiding this comment.
[nitpick] The shebang line should have a space after the hash-bang. The correct format is #! /usr/bin/env bun (with a space after #!).
Suggested change
| #!/usr/bin/env bun | |
| #! /usr/bin/env bun |
mihaibudiu
approved these changes
Dec 5, 2025
Karakatiza666
force-pushed
the
fix-ui-5
branch
from
79e2cec to
020bc4a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Karakatiza666
force-pushed
the
fix-ui-5
branch
from
020bc4a to
d51e99f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
I need to find the cause of CI issue and will then merge. |
Karakatiza666
force-pushed
the
fix-ui-5
branch
from
d51e99f to
2d75b17
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…rted version Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Karakatiza666
force-pushed
the
fix-ui-5
branch
from
2d75b17 to
6f97925
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the name of downloaded support bundle
