pipeline-manager: deployment resources status details #5319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds detailed status information for deployment resources and runtime status in the pipeline manager. The changes enable tracking of granular status details throughout the pipeline lifecycle (provisioning, provisioned, stopping states) to provide better visibility into pipeline deployment health and progress.
- Introduces
deployment_resources_status_detailsanddeployment_runtime_status_detailsfields to store JSON status information - Refactors the state machine to use
Actionenum with more granular state transitions includingRemainProvisioning,RemainProvisioned, andRemainStoppingactions - Updates the
PipelineExecutortrait to return status details fromis_provisioned()andcheck()methods
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openapi.json | Adds nullable deployment_resources_status_details and deployment_runtime_status_details fields to API schema |
| crates/pipeline-manager/src/runner/pipeline_executor.rs | Introduces ProvisionStatus enum and updates trait methods to return status details |
| crates/pipeline-manager/src/runner/pipeline_automata.rs | Refactors state machine from State to Action enum with detailed transition handling and status detail tracking |
| crates/pipeline-manager/src/runner/local_runner.rs | Updates local runner implementation to provide status details |
| crates/pipeline-manager/src/runner/error.rs | Adds conversion from RunnerError to ErrorResponse |
| crates/pipeline-manager/src/error.rs | Adds conversion from ManagerError to ErrorResponse |
| crates/pipeline-manager/src/db/types/pipeline.rs | Adds status details fields to pipeline descriptor |
| crates/pipeline-manager/src/db/test.rs | Updates test code with new status details parameters |
| crates/pipeline-manager/src/db/storage_postgres.rs | Refactors database operations to handle status details with new remain_* methods |
| crates/pipeline-manager/src/db/storage.rs | Adds trait methods for remaining in current status while updating details |
| crates/pipeline-manager/src/db/operations/pipeline.rs | Splits status transition logic into separate methods for each transition type |
| crates/pipeline-manager/src/db/error.rs | Adds conversion from DBError to ErrorResponse |
| crates/pipeline-manager/src/api/support_data_collector.rs | Updates test calls with new status details parameters |
| crates/pipeline-manager/src/api/examples.rs | Adds status details fields to example data structures |
| crates/pipeline-manager/src/api/endpoints/pipeline_management.rs | Adds status details fields to API response structures |
| crates/pipeline-manager/migrations/V31__resources_details.sql | Adds database migration for new status details column |
Adds a new field `deployment_resources_status_details` with information about the status of the (Kubernetes) resources backing the pipeline. The `deployment_runtime_status_details` are now also regularly updated while the pipeline is provisioned. Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
snkas
force-pushed
the
monitor-pipeline
branch
from
bb2235e to
4129ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new field
deployment_resources_status_detailswith information about the status of the (Kubernetes) resources backing the pipeline.The
deployment_runtime_status_detailsare now also regularly updated while the pipeline is provisioned.Remaining tasks
PR information