pg_out: add cdc output mode #5320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds CDC (Change Data Capture) mode to the PostgreSQL output connector, allowing users to write all operations as INSERT operations into an append-only event log with metadata columns for operation type and timestamp.
Key changes:
- Added
PostgresWriteModeenum withMaterialized(default) andCdcmodes - Added configuration options
cdc_op_columnandcdc_ts_columnfor CDC metadata columns - Modified SQL query generation to use INSERT for all operations in CDC mode
- Added comprehensive test coverage for CDC mode across all operation types
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs.feldera.com/docs/connectors/sinks/postgresql.md | Documents the new CDC mode and configuration options |
| crates/feldera-types/src/transport/postgres.rs | Defines PostgresWriteMode enum and adds CDC configuration fields with validation |
| crates/adapters/src/integrated/postgres/test.rs | Adds CDC test variants and PostgresTestStructCdc type for testing |
| crates/adapters/src/integrated/postgres/prepared_statements.rs | Updates query generation to handle CDC mode INSERT operations |
| crates/adapters/src/integrated/postgres/output.rs | Implements CDC metadata serialization and validation |
abhizer
force-pushed
the
pg_event_log
branch
3 times, most recently
from
a7459fa to
0a393dd
Compare
Adds a new config `mode` to `PostgresWriterConfig`, which allows us to use a `cdc` mode. It is also possible to specify the operation and timestamp columns, by default, they are: `__feldera_op` and `__feldera_ts`. - `__feldera_op`: either `i` for insert operations, `u` for upserts or `d` for deletes. - `__feldera_ts`: the UTC timestamp when this record is being serialized. For simplicity, in `cdc` mode, all insert, update and delete queries are the same insert query; this allows us to reuse code and avoid refactors. Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
abhizer
force-pushed
the
pg_event_log
branch
from
0a393dd to
ea6e831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5263
Adds a new config
modetoPostgresWriterConfig, which allows us to use acdcmode. It is also possible to specify the operation and timestamp columns, by default, they are:__feldera_opand__feldera_ts.__feldera_op: eitherifor insert operations,ufor upserts ordfor deletes.__feldera_ts: the UTC timestamp when this record is being serialized.For simplicity, in
cdcmode, all insert, update and delete queries are the same insert query; this allows us to reuse code and avoid refactors.