QoL improvements for working with ideal gas models #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
prehner
force-pushed
the
ideal_gas_finetuning
branch
from
612f97f to
880ad93
Compare
prehner
force-pushed
the
ideal_gas_finetuning
branch
from
ead51a9 to
d4b2f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains four smaller proposed changes that are each open to discussion individually.
molarweightfield is removed fromPureRecordand added toPcSaftRecordinstead (the other eos would have to be updated as well)A newNoResidualstruct is used (internally) to be able to construct anEquationOfStatewith only an ideal gas model, e.g.EquationOfStatewithout residual model #204Arcaround the ideal gas part inEquationOfStateis removed. The correspondingArcaround the residual part is required exactly once for the "building" pattern forEquationOfStatein Python. I would prefer to also get rid of that, because it is unnecessary for Rust and conceptually not required at that point. That would require a different constructor forEquationOfStatein Python, though.PureRecord,SegmentRecord,Identifier, andIdentifierOptionare added tofeos.ideal_gas. This is related to a larger issue that there are multiplePureRecords andSegmentRecords in the Python package.IdentifierandIdentifierOptioncould be exposed only once at a central location.PureRecordand other Python classes tofeos.ideal_gas#205The changes in 1. and 3. are breaking changes, but 2. is a nice quality of life improvement that could be published as patch. 4. more of a fix, but does not really solve the root of the problem.