Reimplement Molarweight trait #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prehner
force-pushed
the
molarweight
branch
2 times, most recently
from
c327609 to
88a5eb9
Compare
g-bauer
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 The
Molarweighttrait makes a comeback 💥Analogous to
EntropyScaling, implementing molar weights for models in Rust becomes optional again. Specific properties can thus only be evaluated if the trait is implemented.IIRC, the last time around this lead to crashes due to panics within getters? The
StateVecgetters that require a molar weight and theto_dictmethods will now check first if the given variant provides a molar weight.