xdiff: Fix outdated comments referring to "ha" member var #2139
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Op-Amp Frequency Response and Applications Suite
Contributor
Author
|
/preview |
|
There is an issue in commit 8573eef:
|
The `ha` member variable was refactored to separate `line_hash` and `minimal_perfect_hash` ones in 6a26019. However, there is a stale comment in xpatience.c that still refers to it. Fix the comment to make sure it is consistent with code. Signed-off-by: Yee Cheng Chin <ychin.git@gmail.com>
ychin
force-pushed
the
fix-patience-diff-wrong-ha-docs
branch
from
8573eef to
813d04b
Compare
|
Preview email sent as pull.2139.git.git.1766461273670.gitgitgadget@gmail.com |
Contributor
Author
|
/submit |
|
Submitted as pull.2139.git.git.1766464905719.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: Ezekiel Newren ezekielnewren@gmail.com