unicode() --> six.u() for Python 3 compatibility #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__unicode()__ was removed from Python 3 because all strs are unicode. Executing these lines in Python 3 would raise a NameError. * https://pythonhosted.org/six/#six.u
Collaborator
|
lgtm!, thanks |
|
What is 120:60:130:LG simplink up skaleing hdmi---------4/4/4/3/4/4...0hms
speakers
---------- Forwarded message ----------
From: "cclauss" <notifications@github.com>
Date: Jan 10, 2018 7:06 PM
Subject: [google/python-fire] unicode() --> six.u() for Python 3
compatibility (#111)
To: "google/python-fire" <python-fire@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
*unicode()* was removed from Python 3 because all strs are unicode.
Executing these lines in Python 3 would raise a NameError.
- https://pythonhosted.org/six/#six.u
…------------------------------
You can view, comment on, or merge this pull request online at:
#111
Commit Summary
- unicode() --> six.u() for Python 3 compatibility
File Changes
- *M* fire/parser_fuzz_test.py
<https://github.com/google/python-fire/pull/111/files#diff-0> (4)
Patch Links:
- https://github.com/google/python-fire/pull/111.patch
- https://github.com/google/python-fire/pull/111.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#111>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZJFGwy5S5dCOd9Jl3S_34B51V55hv0kks5tJVCBgaJpZM4RaIWH>
.
|
Collaborator
|
Turns out |
Contributor
Author
|
six.text_type() seems like a better substitute. |
Collaborator
|
Yeah, that looks right. Thanks. |
cclauss
pushed a commit
to cclauss/python-fire
that referenced
this pull request
Jun 22, 2018
dbieber
pushed a commit
that referenced
this pull request
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode() was removed from Python 3 because all strs are unicode.
Executing these lines in Python 3 would raise a NameError.